Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-20721: RBAC Group Resource DB implementation #6257

Merged
merged 13 commits into from
Jul 5, 2024
Merged

CORE-20721: RBAC Group Resource DB implementation #6257

merged 13 commits into from
Jul 5, 2024

Conversation

Tom-Fitzpatrick
Copy link
Contributor

@Tom-Fitzpatrick Tom-Fitzpatrick commented Jul 4, 2024 •
edited
Loading

Completes the implementation of the RBAC Group Rest Resource, adding the db side of the implementation with unit tests.

@Tom-Fitzpatrick
add implementation for DB side of RBAC Group operations
20465e4 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
complete changeParentId, add logic to throw during deleteGroup if not…
aa78cfd 
… empty

Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
added Create and ChangeParentGroupId tests to GroupWriterImplTest
59ab477 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
tidy up tests
28eadb1 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
add tests for addRole to Group
50f95b0 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
fix add role to group test
2a9e6f6 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
add tests for delete Group,change thrown exception type when group no…
f1b7717 
…t empty

Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
add group cases to PermissionStorageWriterProcessorImplTest
f4e124d 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
detekt
0ebe756 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
fix more detekt
9b5b0f3 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
Merge branch 'release/os/5.3' into tomf/CORE-20721/rbac-group-db-impl…
924983a 
…ementation
@Tom-Fitzpatrick
add api methods to ClusterBuilder
cdb0ee2 
Signed-off-by: TomFitzpatrick <[email protected]>
@Tom-Fitzpatrick
update swaggerBaseline with small change
9e7a2ec 
Signed-off-by: TomFitzpatrick <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 6257 build 6

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1720105726260
Helm chart version produced by this PR: 5.3.0-alpha.1720105726260
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6257/corda
Helm chart Polaris score: 82

@Tom-Fitzpatrick Tom-Fitzpatrick marked this pull request as ready for review July 4, 2024 15:37
@Tom-Fitzpatrick Tom-Fitzpatrick requested a review from a team as a code owner July 4, 2024 15:37
@Tom-Fitzpatrick Tom-Fitzpatrick self-assigned this Jul 4, 2024
vkolomeyko
vkolomeyko approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Fitzpatrick Tom-Fitzpatrick merged commit eacdfd1 into release/os/5.3 Jul 5, 2024
5 checks passed
@Tom-Fitzpatrick Tom-Fitzpatrick deleted the tomf/CORE-20721/rbac-group-db-implementation branch July 5, 2024 11:14
emilybowe pushed a commit that referenced this pull request Jul 5, 2024
@Tom-Fitzpatrick @emilybowe
CORE-20721: RBAC Group Resource DB implementation (#6257)
2dc089d 
Completes the implementation of the RBAC Group Rest Resource, adding the db side of the implementation with unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

Assignees

@Tom-Fitzpatrick Tom-Fitzpatrick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tom-Fitzpatrick @vkolomeyko