Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-20756: Add property permissions to UserAdmin role #6258

Merged
merged 6 commits into from
Jul 4, 2024
Merged

CORE-20756: Add property permissions to UserAdmin role #6258

merged 6 commits into from
Jul 4, 2024

Conversation

aadhavskthvl
Copy link
Contributor

Permissions given to UserAdmin are:
-Add property to user
-Remove property from user
-List properties of user
-Find user by property

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 4, 2024 •
edited
Loading

Jenkins build for PR 6258 build 2

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1720103098676
Helm chart version produced by this PR: 5.3.0-alpha.1720103098676
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6258/corda
Helm chart Polaris score: 82

@aadhavskthvl aadhavskthvl marked this pull request as ready for review July 4, 2024 14:09
@aadhavskthvl aadhavskthvl requested a review from a team as a code owner July 4, 2024 14:09
@aadhavskthvl aadhavskthvl requested a review from a team July 4, 2024 14:10
@aadhavskthvl aadhavskthvl marked this pull request as draft July 4, 2024 14:19
@aadhavskthvl aadhavskthvl marked this pull request as ready for review July 4, 2024 14:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vkolomeyko
vkolomeyko approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aadhavskthvl aadhavskthvl merged commit 493319a into release/os/5.3 Jul 4, 2024
5 checks passed
@aadhavskthvl aadhavskthvl deleted the CORE-20756/add-permissions-to-UserAdminRole branch July 4, 2024 15:34
emilybowe pushed a commit that referenced this pull request Jul 5, 2024
@aadhavskthvl @emilybowe
CORE-20756: Add property permissions to UserAdmin role (#6258)
182fb62 
Adds following property permissions to UserAdmin are:
-Add property to user
-Remove property from user
-List properties of user
-Find user by property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadhavskthvl @vkolomeyko