Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20763 - Eliminate support of DurableStream #6260

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

filipesoliveira
Copy link
Contributor

@filipesoliveira filipesoliveira commented Jul 5, 2024

DurableStream functionality is redundant in REST API and is never used in production to deliver any sort of feed. Therefore any references to net.corda.rest.durablestream have been removed from the codebase.

The following tests must be green before merging the PR:

  • Unit tests (Done)
  • Integration tests (Done)
  • Smoke tests (Done)
  • E2e tests (Done)
  • QA regression tests (Done)

@filipesoliveira filipesoliveira requested a review from a team as a code owner July 5, 2024 10:48
@filipesoliveira filipesoliveira marked this pull request as draft July 5, 2024 10:48
Copy link

sonarcloud bot commented Jul 5, 2024

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 6260 build 4

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1720184268490
Helm chart version produced by this PR: 5.3.0-alpha.1720184268490
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6260/corda
Helm chart Polaris score: 82

@filipesoliveira
Copy link
Contributor Author

filipesoliveira commented Jul 5, 2024

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 5, 2024

Building E2E Tests on PR-6260

Succeeded

@filipesoliveira
Copy link
Contributor Author

The Q.A. regression tests are now being run.

References:

@filipesoliveira
Copy link
Contributor Author

@filipesoliveira filipesoliveira marked this pull request as ready for review July 8, 2024 12:43
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipesoliveira filipesoliveira merged commit bfcf929 into release/os/5.3 Jul 8, 2024
9 checks passed
@filipesoliveira filipesoliveira deleted the filipe.oliveira/CORE-20763 branch July 8, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants