CORE-20794 Catching ProducerFencedException and rethrowing as a ProducerRequiresReset #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-millar
force-pushed
the
bm/CORE-20794/wrapping-fenced-exception
branch
from
2a682a1
to
0a03f8d
Compare
|
|
Jenkins build for PR 6303 build 2 Build Successful: |
LWogan
approved these changes
Jul 29, 2024
LWogan
pushed a commit
that referenced
this pull request
Oct 3, 2024
…cerRequiresReset (#6303) The `ProducerFencedException` in these cases is likely due to an invalid epoch being used in an operation as a result of a timeout on the broker side. The correct action in this case is to reset the producer.
LWogan
pushed a commit
that referenced
this pull request
Oct 8, 2024
…cerRequiresReset (#6303) The `ProducerFencedException` in these cases is likely due to an invalid epoch being used in an operation as a result of a timeout on the broker side. The correct action in this case is to reset the producer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kafka broker failure resiliency tests, we were seeing
ProducerFencedExceptionsbeing thrown. Typically, these are as a result of trying to create a producer with atransactional.idwhich is still in use, however that shouldn't be possible in this situation.Further investigation showed that a producer could also be fenced if it attempts an operation using an old epoch; this is a more likely option, due to a broker-side timeout caused by the injected Kafka failure. To combat this, we should catch the
ProducerFencedExceptionand re-throw it as aProducerRequiresReset, which will trigger the producer to be safely reset in dependent components.