-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-20803: Add validation to prevent changeParentGroup creating circular group hierarchies #6304
CORE-20803: Add validation to prevent changeParentGroup creating circular group hierarchies #6304
Conversation
…ierarchies Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Jenkins build for PR 6304 build 8 Build Successful: |
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
...ain/kotlin/net/corda/libs/permissions/storage/writer/impl/validation/EntityValidationUtil.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/net/corda/libs/permissions/storage/writer/impl/validation/EntityValidationUtil.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds validation to prevent a changeGroupParent request resulting in a circular group hierarchy.
Added e2e test for this scenario here: https://github.com/corda/corda-e2e-tests/pull/688