Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support audio devicechange event #631

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jerry2013
Copy link
Contributor

using existing audio output notification to emit media devicechange event

@jerry2013 jerry2013 closed this Jan 14, 2021
@hthetiot hthetiot added this to the 6.0.17 milestone Jan 14, 2021
@hthetiot hthetiot added enhancement webrtc-api webrtc-api related labels Jan 14, 2021
@hthetiot hthetiot self-requested a review January 14, 2021 23:41
@hthetiot
Copy link
Contributor

That cool why did you close ?

@hthetiot hthetiot reopened this Jan 14, 2021
@jerry2013
Copy link
Contributor Author

I found that turning off paired Bluetooth headset does not get the event for audioRouteChangeListener, at least not consistently. I'm not familiar with iOS at all so I don't know how to address the issue, so I'd rather not have this to avoid having people rely on something that's unreliable.

If someone knows how to get the right event in iOS, the rest of the code is solid (I think, as pairing a new Bluetooth works quite well - it might need a timeout before dispatch the event as I don't know if iOS update availableInputs before or after).

@hthetiot hthetiot closed this Jan 15, 2021
@hthetiot
Copy link
Contributor

if someone knows how to get the right event in iOS, the rest of the code is solid (I think, as pairing a new Bluetooth works quite well - it might need a timeout before dispatch the event as I don't know if iOS update availableInputs before or after).

Let leave it open then :)

@hthetiot hthetiot reopened this Jan 15, 2021
@hthetiot
Copy link
Contributor

Can you convert to draft @jerry2013 thx

@hthetiot hthetiot removed this from the 6.0.17 milestone Jan 20, 2021
@jerry2013 jerry2013 marked this pull request as draft January 20, 2021 13:26
@hthetiot hthetiot added this to the 6.1.x milestone Jan 20, 2021
@hthetiot
Copy link
Contributor

Thank you @jerry2013

@hthetiot hthetiot modified the milestones: 6.1.x, triage Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement webrtc-api webrtc-api related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants