#31 : Alternate editor color schemes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit need some cleanup and a proper alternate theme, preference storage and javascript cleanup is needed too.
- Add jquery.cookie.js to store a preference cookie for 30 days (a .niderc maybe a proper solution to store user preferences); - Create a dialog.html file to avoid html within javascript - Update styles with dialog related properties - Update CodeEditor.js to use our stored value when creating new editors
|
Wow, this is such a great addition! Thanks! I'm sorry for the time it took for me to look into/merge this. Lately I haven't had any time for open source projects like nide due to college. |
coreh
added a commit
that referenced
this pull request
Apr 17, 2012
…r-schemes #31 : Alternate editor color schemes
|
Nice commit! Pesky college. Didn't stop Bill or Steve. All the same, I'm glad I stayed in school. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for your amazing work.
Here's my work on alternate color schemes relative to issue #31 from @cmundi. I wrote a basic theme support with cookie storage across sessions.
Comments are welcome !