Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch main #2

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Patch main #2

wants to merge 10 commits into from

Conversation

c4rt0
Copy link
Member

@c4rt0 c4rt0 commented Jun 10, 2024

update main.tf

@jbtrystram jbtrystram mentioned this pull request Jun 10, 2024
Closed
@c4rt0
Copy link
Member Author

c4rt0 commented Jun 10, 2024

Ok, I think I messed up something here with the last push.
cc. @jbtrystram

jbtrystram
jbtrystram suggested changes Jun 10, 2024
View reviewed changes
fedora-coreos/provisioning/main.tf Outdated Show resolved Hide resolved
fedora-coreos/provisioning/main.tf Outdated Show resolved Hide resolved
@jbtrystram
Copy link

jbtrystram commented Jun 10, 2024 •
edited
Loading

Ok, I think I messed up something here with the last push.

@c4rt0 I still have my stuff locally, that's fine.
I fyou want to add new changes makes sure doing git pull -r first :)

jbtrystram and others added 3 commits June 11, 2024 09:34
@jbtrystram
provisionning: move launch script to this repo
eecb90c
@jbtrystram
provisionning: add a dummy ignition file
6211ea6 
This is a required workaround for the `lauch_coreos_vm` script
otherwhise it runs into expanding variables issue when no ignition
config is provided so we pass this empty one
@c4rt0
Port automatic ami recognition
d9ea4e5 
ref: coreos@9737671
jbtrystram added a commit to jbtrystram/devconf24-coreos-workshop that referenced this pull request Jun 11, 2024
@jbtrystram
Move lauch vm script to https://github.com/coreos/coreos-tutorials
c4b9eda 
See coreos/coreos-tutorials#2
travier
travier approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged now that the workshop is done?

@c4rt0 c4rt0 requested a review from jbtrystram July 30, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@jbtrystram jbtrystram Awaiting requested review from jbtrystram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c4rt0 @jbtrystram @travier