New config! (changesets#132)

* Start of new config things!

* Add changes to types

* More stuff

* Some stuff

* Add tests and fix things

* Fix things

* fix All The Things

* Update snapshots

* Fix type things

* Fix linting

* whoops, nearly forgot changesets

.changeset/hip-crews-wave/changes.json

@@ -0,0 +1,6 @@
+{
+  "releases": [
+    { "name": "@changesets/assemble-release-plan", "type": "patch" }
+  ],
+  "dependents": []
+}

.changeset/hip-crews-wave/changes.md

@@ -0,0 +1 @@
+Use new Config type which makes linked required

.changeset/hungry-drinks-lay/changes.json

@@ -0,0 +1,30 @@
+{
+  "releases": [{ "name": "@changesets/types", "type": "minor" }],
+  "dependents": [
+    {
+      "name": "@changesets/assemble-release-plan",
+      "type": "patch",
+      "dependencies": ["@changesets/config", "@changesets/types"]
+    },
+    {
+      "name": "@changesets/config",
+      "type": "patch",
+      "dependencies": ["@changesets/types"]
+    },
+    {
+      "name": "get-dependents-graph",
+      "type": "patch",
+      "dependencies": ["@changesets/types"]
+    },
+    {
+      "name": "@changesets/parse",
+      "type": "patch",
+      "dependencies": ["@changesets/types"]
+    },
+    {
+      "name": "@changesets/read",
+      "type": "patch",
+      "dependencies": ["@changesets/parse", "@changesets/types"]
+    }
+  ]
+}

.changeset/hungry-drinks-lay/changes.md

@@ -0,0 +1 @@
+Add WrittenConfig type and include all properties in Config type

.changeset/many-impalas-march/changes.json

@@ -0,0 +1,10 @@
+{
+  "releases": [{ "name": "@changesets/config", "type": "minor" }],
+  "dependents": [
+    {
+      "name": "@changesets/assemble-release-plan",
+      "type": "patch",
+      "dependencies": ["@changesets/config"]
+    }
+  ]
+}

.changeset/many-impalas-march/changes.md

@@ -0,0 +1 @@
+Initial release with parse and read functions along with defaultConfig and defaultWrittenConfig

__fixtures__/new-config/.changeset/config.json

@@ -0,0 +1,4 @@
+{
+  "changelog": false,
+  "commit": true
+}

package.json

@@ -35,6 +35,7 @@
     "@babel/runtime": "^7.4.4",
     "@types/fs-extra": "^5.1.0",
     "@types/jest": "^24.0.12",
+    "@types/jest-in-case": "^1.0.1",
     "@types/js-yaml": "^3.12.1",
     "@types/meow": "^5.0.0",
     "@types/semver": "^6.0.0",
@@ -68,6 +69,7 @@
     "is-ci": "^2.0.0",
     "jest": "^24.7.1",
     "jest-fixtures": "^0.5.0",
+    "jest-in-case": "^1.0.2",
     "jest-junit": "^6.4.0",
     "js-yaml": "^3.13.1",
     "lodash.startcase": "^4.4.0",
@@ -76,7 +78,7 @@
     "outdent": "^0.5.0",
     "p-limit": "^2.2.0",
     "pkg-dir": "^4.1.0",
-    "preconstruct": "^0.0.79",
+    "preconstruct": "^0.0.84",
     "prettier": "^1.14.3",
     "semver": "^5.4.1",
     "spawndamnit": "^2.0.0",

packages/assemble-release-plan/package.json

@@ -9,5 +9,8 @@
   "dependencies": {
     "@changesets/types": "^0.0.0",
     "semver": "^5.4.1"
+  },
+  "devDependencies": {
+    "@changesets/config": "^0.0.0"
   }
-}
+}

packages/assemble-release-plan/src/apply-links.ts

@@ -13,10 +13,7 @@ import { Linked, ComprehensiveRelease } from "@changesets/types";
   We could solve this by inlining this function, or by returning a deep-cloned then
   modified array, but we decided both of those are worse than this solution.
 */
-function applyLinks(
-  releases: ComprehensiveRelease[],
-  linked?: Linked
-): boolean {
+function applyLinks(releases: ComprehensiveRelease[], linked: Linked): boolean {
   let updated = false;
   if (!linked) return updated;
 

packages/assemble-release-plan/src/index.test.ts

@@ -1,3 +1,4 @@
+import { defaultConfig } from "@changesets/config";
 import assembleReleasePlan from "./";
 import FakeFullState from "./test-utils";
 
@@ -16,7 +17,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(1);
@@ -42,7 +43,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(4);
@@ -65,7 +66,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toEqual(1);
@@ -84,7 +85,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toEqual(2);
@@ -104,7 +105,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      { linked: [["pkg-a", "pkg-b"]] }
+      { ...defaultConfig, linked: [["pkg-a", "pkg-b"]] }
     );
 
     expect(releases.length).toEqual(2);
@@ -134,7 +135,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      { linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
+      { ...defaultConfig, linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
     );
 
     expect(releases.length).toEqual(4);
@@ -148,7 +149,7 @@ describe("assemble-release-plan", () => {
       [],
       setup.workspaces,
       setup.dependentsGraph,
-      { linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
+      { ...defaultConfig, linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
     );
 
     expect(releases).toEqual([]);
@@ -161,7 +162,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      { linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
+      { ...defaultConfig, linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
     );
 
     expect(releases.length).toEqual(3);
@@ -180,7 +181,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      { linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
+      { ...defaultConfig, linked: [["pkg-a", "pkg-b"], ["pkg-c", "pkg-d"]] }
     );
 
     expect(releases.length).toEqual(3);
@@ -202,7 +203,7 @@ describe("assemble-release-plan", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toEqual(2);
@@ -231,7 +232,7 @@ describe("version update thoroughness", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
     expect(releases.length).toEqual(2);
     expect(releases[0].name).toEqual("pkg-a");
@@ -249,7 +250,7 @@ describe("version update thoroughness", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toEqual(3);
@@ -270,7 +271,7 @@ describe("version update thoroughness", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toEqual(4);
@@ -299,7 +300,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(2);
@@ -315,7 +316,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(1);
@@ -333,7 +334,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(2);
@@ -353,7 +354,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(2);
@@ -369,7 +370,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(1);
@@ -387,7 +388,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(2);
@@ -407,7 +408,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(2);
@@ -429,7 +430,7 @@ describe("bumping peerDeps", () => {
       setup.changesets,
       setup.workspaces,
       setup.dependentsGraph,
-      {}
+      defaultConfig
     );
 
     expect(releases.length).toBe(3);

packages/config/README.md

@@ -0,0 +1,21 @@
+# @changesets/config
+
+> Utilities for reading and parsing Changeset's config
+
+```tsx
+import { parse, read, ValidationError } from "@changesets/config";
+
+let config = await read(process.cwd(), workspaces);
+
+let config = parse({ commit: true }, workspaces);
+
+try {
+  return parse({ commit: true }, workspaces);
+} catch (err) {
+  if (err instanceof ValidationError) {
+    let message = err.message;
+  } else {
+    throw err;
+  }
+}
+```

packages/config/package.json

@@ -0,0 +1,21 @@
+{
+  "name": "@changesets/config",
+  "version": "0.0.0",
+  "description": "Utilities for reading and parsing Changeset's config",
+  "main": "dist/config.cjs.js",
+  "module": "dist/config.esm.js",
+  "license": "MIT",
+  "repository": "https://github.com/changesets/changesets/tree/master/packages/config",
+  "files": [
+    "dist",
+    "schema.json"
+  ],
+  "dependencies": {
+    "@changesets/types": "^0.0.0",
+    "fs-extra": "^7.0.1"
+  },
+  "devDependencies": {
+    "fixturez": "^1.1.0",
+    "jest-in-case": "^1.0.2"
+  }
+}