Move benchmarks to an independent project #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhosv
commented
Sep 5, 2023
| @@ -1,8 +1,10 @@ | |||
| // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| package com.amazon.corretto.crypto.provider; | |||
There was a problem hiding this comment.
When using published ACCP for benchmarking, it complains that the benchmark package is not consistent with ACCP's signed JAR. To resolve this issue, the benchmark code is moved to com.amazon.corretto.crypto.provider.benchmarks from com.amazon.corretto.crypto.provider.
* Benchmarks now depend on ACCP and there is no need to build ACCP * Benchmarks can be run against published ACCP artifacts on Maven
amirhosv
commented
Sep 6, 2023
| jmhResultPath = "${jmhReportOutput}/results.json" | ||
| } | ||
|
|
||
| tasks.jmh { |
There was a problem hiding this comment.
This block ensures jmhReport is executed after jmh.
WillChilds-Klein
approved these changes
Sep 6, 2023
amirhosv
requested review from
geedo0 and
brian-jarvis-aws
and removed request for
geedo0 and
brian-jarvis-aws
|
Thanks for doing this! This'll solve a lot of annoying problems related to the awkward JMH source set breaking conventions in IDEs and Gradle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move benchmarks to an independent project
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.