Apply the rule of 3/5/0 to JByteArrayCritical et al. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the [rule of 3/5/0](https://en.cppreference.com/w/cpp/language/rule_of_three) to JByteArrayCritical, SimpleBuffer, JBinaryBlob, JIOBlobs. This ensures that these objects cannot be copied. Before, if they were copied (e.g., due to being passed as argument to a function), the destructor would be called twice, which would release the critical region twice or which may release the critical region while another part of the code is still using it.
fabrice102
force-pushed
the
JByteArrayCritical-rule-of-three
branch
from
70cf179
to
ef73412
Compare
geedo0
reviewed
Aug 5, 2024
geedo0
approved these changes
Aug 5, 2024
amirhosv
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Apply the rule of 3/5/0 to
JByteArrayCritical,SimpleBuffer,JBinaryBlob,JIOBlobs. This ensures that these objects cannot be copied.Before, if they were copied (e.g., due to being passed as argument to a function), the destructor would be called twice, which would release the critical region twice or which may release the critical region while another part of the code is still using it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.