Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab Issues Plugin #11

Merged
merged 39 commits into from
Oct 28, 2023
Merged

GitLab Issues Plugin #11

merged 39 commits into from
Oct 28, 2023

Conversation

greg-p-cortex
Copy link
Contributor

Created by Cortex

@FoodProduct
Copy link
Contributor

Going to mark this as draft -- put it back into review when you want eyes on it 👀.

@FoodProduct FoodProduct marked this pull request as draft August 14, 2023 23:15
@cremerfc cremerfc marked this pull request as ready for review October 12, 2023 20:11
FoodProduct
FoodProduct reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@FoodProduct FoodProduct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking close!

plugins/gitlab-issues-plugin/cortex.yaml Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/assets/logo.svg Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/api/Cortex.ts Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/App.test.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/Issues.test.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/Issues.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/Issues.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/PluginContext.tsx Outdated Show resolved Hide resolved
@cortexapps cortexapps deleted a comment from FoodProduct Oct 16, 2023
FoodProduct
FoodProduct reviewed Oct 24, 2023
View reviewed changes
plugins/gitlab-issues-plugin/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/package.json Outdated Show resolved Hide resolved
plugins/gitlab-issues-plugin/src/components/PluginContext.tsx Outdated Show resolved Hide resolved
@cremerfc
Copy link

@FoodProduct I resolved all comments, please review (hopefully) one last time?

FoodProduct
FoodProduct reviewed Oct 25, 2023
View reviewed changes
plugins/gitlab-issues/src/components/EntityInfo.test.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/api/Cortex.ts Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/components/Issues.tsx Show resolved Hide resolved
plugins/gitlab-issues/src/components/Issues.tsx Show resolved Hide resolved
plugins/gitlab-issues/src/components/Issues.tsx Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/lib/parseEntity.ts Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/lib/parseEntity.ts Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/lib/parseEntity.ts Outdated Show resolved Hide resolved
cremerfc and others added 8 commits October 25, 2023 12:56
FoodProduct
FoodProduct reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@FoodProduct FoodProduct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last ask then LGTM!

plugins/gitlab-issues/src/components/Issues.tsx Show resolved Hide resolved
FoodProduct
FoodProduct reviewed Oct 26, 2023
View reviewed changes
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/src/components/Issues.tsx Outdated Show resolved Hide resolved
FoodProduct
FoodProduct previously approved these changes Oct 27, 2023
View reviewed changes
@FoodProduct FoodProduct changed the title [Cortex Scaffolder] Creating new service: Gitlab Issues Plugin GitLab Issues Plugin Oct 28, 2023
FoodProduct
FoodProduct reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@FoodProduct FoodProduct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some copy cleanup

plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
plugins/gitlab-issues/README.md Outdated Show resolved Hide resolved
FoodProduct
FoodProduct approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@FoodProduct FoodProduct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@FoodProduct FoodProduct merged commit 2f00711 into master Oct 28, 2023
1 check passed
@FoodProduct FoodProduct deleted the gitlab-issues-plugin branch October 28, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cremerfc cremerfc cremerfc left review comments

@FoodProduct FoodProduct FoodProduct approved these changes

@cristinabuenahora cristinabuenahora Awaiting requested review from cristinabuenahora cristinabuenahora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greg-p-cortex @FoodProduct @cremerfc