-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cortex.yaml #31
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments and noted where the indentation seemed off
examples/yaml/cortex.yaml
Outdated
# Note the metadata section above is customizable. | ||
# <key>: <value> | ||
# aws: #Use if drawing dependency edges between resources in cloud providr<>services | ||
# tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'tags' indentation looks off? Might still work but docs have it two spaces under aws
examples/yaml/cortex.yaml
Outdated
@@ -125,6 +169,20 @@ info: | |||
# x-cortex-bugsnag: | |||
# project: <PROJECT_KEY> # projectKey in Bugsnag | |||
|
|||
# Buildkite | |||
# x-cortex-ci-cd: | |||
# buildkite: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildkite
needs indented
examples/yaml/cortex.yaml
Outdated
|
||
# Checkmarx | ||
# x-cortex-checkmarx: | ||
# projects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projects
needs to be indented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments and noted where the indentation seemed off
@cremerfc updated per feedback. mind re-reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Add in new integrations, domains, and combine resources