Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cortex.yaml #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update cortex.yaml #31

wants to merge 5 commits into from

Conversation

ToddRizley
Copy link
Contributor

Add in new integrations, domains, and combine resources

@cremerfc cremerfc self-requested a review May 22, 2023 18:31
Copy link
Contributor

@cremerfc cremerfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments and noted where the indentation seemed off

examples/yaml/cortex.yaml Show resolved Hide resolved
examples/yaml/cortex.yaml Show resolved Hide resolved
examples/yaml/cortex.yaml Show resolved Hide resolved
# Note the metadata section above is customizable.
# <key>: <value>
# aws: #Use if drawing dependency edges between resources in cloud providr<>services
# tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'tags' indentation looks off? Might still work but docs have it two spaces under aws

@@ -125,6 +169,20 @@ info:
# x-cortex-bugsnag:
# project: <PROJECT_KEY> # projectKey in Bugsnag

# Buildkite
# x-cortex-ci-cd:
# buildkite:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildkite needs indented


# Checkmarx
# x-cortex-checkmarx:
# projects:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects needs to be indented

Copy link
Contributor

@cremerfc cremerfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments and noted where the indentation seemed off

@ToddRizley ToddRizley closed this May 22, 2023
@ToddRizley ToddRizley deleted the update-postman branch May 22, 2023 23:38
@ToddRizley ToddRizley restored the update-postman branch May 22, 2023 23:40
@ToddRizley ToddRizley reopened this May 22, 2023
@ToddRizley
Copy link
Contributor Author

@cremerfc updated per feedback. mind re-reviewing?

@ToddRizley ToddRizley requested a review from cremerfc May 22, 2023 23:43
Copy link
Contributor

@cremerfc cremerfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants