Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream_protocol reference in auth_orgs #509

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

kd7lxl
Copy link
Collaborator

@kd7lxl kd7lxl commented Sep 24, 2024

What this PR does:
auth_orgs was broken because inside the range the upstream protocol feature tried to read the variable from local scope when it only exists in global scope.

Demo:

% helm template . --set config.auth_enabled=true --set 'nginx.config.auth_orgs={org_name}' > /dev/null
Error: template: cortex/templates/nginx/nginx-dep.yaml:28:28: executing "cortex/templates/nginx/nginx-dep.yaml" at <include (print $.Template.BasePath "/nginx/nginx-config.yaml") .>: error calling include: template: cortex/templates/nginx/nginx-config.yaml:163:36: executing "cortex/templates/nginx/nginx-config.yaml" at <.Values.nginx.config.upstream_protocol>: can't evaluate field Values in type interface {}

Use --debug flag to render out invalid YAML

Which issue(s) this PR fixes:
Fixes bug in #506

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@kd7lxl kd7lxl requested a review from nschad September 24, 2024 18:00
@kd7lxl kd7lxl merged commit 7fb3773 into master Sep 25, 2024
2 checks passed
@nschad nschad deleted the fix-upstream-protocol branch September 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants