Skip to content

Commit

Permalink
test: fix sims (#21735)
Browse files Browse the repository at this point in the history
  • Loading branch information
julienrbrt authored Sep 15, 2024
1 parent 5909f0a commit 0147347
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 6 deletions.
14 changes: 12 additions & 2 deletions .github/workflows/sims-052.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ jobs:
sims-notify-success:
needs:
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
[
test-sim-multi-seed-short,
test-sim-after-import,
test-sim-import-export,
test-sim-deterministic,
]
runs-on: large-sdk-runner
if: ${{ success() }}
steps:
Expand All @@ -120,7 +125,12 @@ jobs:
permissions:
contents: none
needs:
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
[
test-sim-multi-seed-short,
test-sim-after-import,
test-sim-import-export,
test-sim-deterministic,
]
runs-on: large-sdk-runner
if: ${{ failure() }}
steps:
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/sims.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ jobs:
sims-notify-success:
needs:
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
[
test-sim-multi-seed-short,
test-sim-after-import,
test-sim-import-export,
test-sim-deterministic,
]
runs-on: large-sdk-runner
if: ${{ success() }}
steps:
Expand Down Expand Up @@ -111,7 +116,12 @@ jobs:
permissions:
contents: none
needs:
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
[
test-sim-multi-seed-short,
test-sim-after-import,
test-sim-import-export,
test-sim-deterministic,
]
runs-on: large-sdk-runner
if: ${{ failure() }}
steps:
Expand Down
7 changes: 6 additions & 1 deletion server/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,12 @@ func (m mapGetter) Get(key string) interface{} {
}

func (m mapGetter) GetString(key string) string {
return m[key].(string)
str, ok := m[key]
if !ok {
return ""
}

return str.(string)
}

var _ servertypes.AppOptions = mapGetter{}
7 changes: 6 additions & 1 deletion testutils/sims/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,12 @@ func (f AppOptionsFn) Get(k string) any {
}

func (f AppOptionsFn) GetString(k string) string {
return f(k).(string)
str, ok := f(k).(string)
if !ok {
return ""
}

return str
}

// FauxMerkleModeOpt returns a BaseApp option to use a dbStoreAdapter instead of
Expand Down

0 comments on commit 0147347

Please sign in to comment.