Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Migrate modules to use Environment #19290

Closed
16 tasks done
tac0turtle opened this issue Jan 30, 2024 · 1 comment
Closed
16 tasks done

[Feature]: Migrate modules to use Environment #19290

tac0turtle opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
C:server/v2 Issues related to server/v2 T:feature-request

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jan 30, 2024

Summary

With the merge of #19041 we introduced a service bundler, this is meant to replace unwrapping context within modules.

Problem Definition

No response

Proposed Feature

Migrate all modules to use environment instead of unwrapping context.

@julienrbrt
Copy link
Member

Explicitly mentioning here that x/params and x/crisis weren't migrated as those modules are deprecated since two major SDK versions.

If a chain wants to use server/v2, which requires services, they must not depend on x/params and x/crisis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 T:feature-request
Projects
Status: 🥳 Done
Development

No branches or pull requests

4 participants