fix: allow tx decoding to fail in GetBlockWithTxs

[facundomedica]

Description

Fixes the GetBlocksWithTxs endpoint (/cosmos/tx/v1beta1/txs/block/{height}) by allowing the decoding of txs to fail silently (but with a log). These failing txs are actually injected vote extensions.

In the future we might want to do something more useful here, like returning the raw bytes, so clients can analyze the vote extensions being used.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Refactor
  • Improved error handling in transaction processing by logging errors for better diagnostics instead of directly returning them.

[coderabbitai]

Walkthrough

Walkthrough

The update in the GetBlockWithTxs function of the txServer in service.go involves a transition in error handling. Previously, errors occurring during decoding were directly returned, but now they are logged using the SDK context logger. This change aims to improve error management and visibility without interrupting the function's flow.

Changes

File	Change Summary
x/auth/tx/service.go	Updated error handling in GetBlockWithTxs function to log errors using SDK context logger.
x/auth/CHANGELOG.md	Added functionality to ignore undecodable transactions in GetBlocksWithTxs.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 83c4b9b and 4120d92.

Files selected for processing (1)

• x/auth/tx/service.go (1 hunks)

Additional Context Used

Path-based Instructions (1)

x/auth/tx/service.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (3)

x/auth/tx/service.go (3)

189-189: Ensure proper logging of decoding errors.

The change to log errors instead of returning them when decoding transactions fails is a good practice for non-critical errors, as it allows the function to continue processing other transactions. This enhances the robustness of the system.

---

195-195: Ensure proper logging of decoding errors.

The consistent application of error logging in both forward and reverse pagination scenarios is good. This ensures that all decoding errors are logged irrespective of the pagination direction.

---

Line range hint 176-211: Review overall function structure and logic.

The function GetBlockWithTxs is well-structured and follows good practices in error handling and pagination. The use of clear and concise error messages, proper pagination handling, and logging enhances maintainability and readability.

[tac0turtle]

utACK, can you add to the description what this is fixing

[coderabbitai]

Actionable comments posted: 2

Out of diff range and nitpick comments (3)

x/auth/CHANGELOG.md (3)

Line range hint 39-39: Consider adding a comma for clarity.

- When signing a transaction with an account that has not been created accountnumber 0 must be used
+ When signing a transaction with an account that has not been created, accountnumber 0 must be used

---

Line range hint 38-38: Remove trailing spaces to maintain clean code formatting.

- * [#19188](https://github.com/cosmos/cosmos-sdk/pull/19188) Remove creation of `BaseAccount` when sending a message to an account that does not exist. 
+ * [#19188](https://github.com/cosmos/cosmos-sdk/pull/19188) Remove creation of `BaseAccount` when sending a message to an account that does not exist.

---

Line range hint 51-53: Correct the indentation for list items to ensure consistency across the document.

- * [#19290](https://github.com/cosmos/cosmos-sdk/issues/19290) Pass `appmodule.Environment` to NewKeeper instead of passing individual services. 
- * [#19535](https://github.com/cosmos/cosmos-sdk/pull/19535) Remove vesting account creation when the chain is running. The accounts module is required for creating vesting accounts on a running chain. 
- * [#19600](https://github.com/cosmos/cosmos-sdk/pull/19600) add a consensus query method to the consensus module in order for modules to query consensus for the consensus params. 
+ * [#19290](https://github.com/cosmos/cosmos-sdk/issues/19290) Pass `appmodule.Environment` to NewKeeper instead of passing individual services.
+ * [#19535](https://github.com/cosmos/cosmos-sdk/pull/19535) Remove vesting account creation when the chain is running. The accounts module is required for creating vesting accounts on a running chain.
+ * [#19600](https://github.com/cosmos/cosmos-sdk/pull/19600) add a consensus query method to the consensus module in order for modules to query consensus for the consensus params.

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4120d92 and ef2afb2.

Files selected for processing (1)

• x/auth/CHANGELOG.md (1 hunks)

Additional Context Used

LanguageTool (19)

x/auth/CHANGELOG.md (19)

Near line 30: Unpaired symbol: ‘[’ seems to be missing
Context: ...## [Unreleased] ### Features * [#18641](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 31: Unpaired symbol: ‘[’ seems to be missing
Context: ...r more details on integration. * [#18281](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 36: Unpaired symbol: ‘[’ seems to be missing
Context: ...g accounts. ### Improvements * [#19967](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 37: Unpaired symbol: ‘[’ seems to be missing
Context: ...ervice` for getting exec mode. * [#18780](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 38: Unpaired symbol: ‘[’ seems to be missing
Context: ... into the authenticate method. * [#19188](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 39: Possible missing comma found.
Context: ...ction with an account that has not been created accountnumber 0 must be used ### CLI B...

---

Near line 47: Unpaired symbol: ‘[’ seems to be missing
Context: ...ed. ### API Breaking Changes * [#19447](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 48: Unpaired symbol: ‘[’ seems to be missing
Context: ...r address codecs as arguments. * [#17985](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 49: Unpaired symbol: ‘[’ seems to be missing
Context: ...ll/17985) Remove StdTxConfig * [#19161](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 50: Unpaired symbol: ‘[’ seems to be missing
Context: ... simulate from SetGasMeter * [#19363](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 51: Unpaired symbol: ‘[’ seems to be missing
Context: ...ntKeeper interface and Keeper. * [#19290](https://github.com/cosmos/cosmos-sdk/is...

---

Near line 52: Unpaired symbol: ‘[’ seems to be missing
Context: ... passing individual services. * [#19535](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 53: Unpaired symbol: ‘[’ seems to be missing
Context: ... accounts on a running chain. * [#19600](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 58: Unpaired symbol: ‘[’ seems to be missing
Context: ...## Consensus Breaking Changes * [#18817](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 59: Unpaired symbol: ‘[’ seems to be missing
Context: ...X validation flow has reduced. * [#19093](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 63: Unpaired symbol: ‘[’ seems to be missing
Context: ...r a simple tx. ### Bug Fixes * [#19148](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 64: Unpaired symbol: ‘[’ seems to be missing
Context: ...y signature during simulation. * [#19239](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 65: Unpaired symbol: ‘[’ seems to be missing
Context: ...id no key name provided error. * [#19099](https://github.com/cosmos/cosmos-sdk/pu...

---

Near line 66: Unpaired symbol: ‘[’ seems to be missing
Context: ...id malformed public key error. * [#20323](https://github.com/cosmos/cosmos-sdk/pu...

Path-based Instructions (1)

x/auth/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

[coderabbitai]

The changelog entry for PR #20323 could be more descriptive to reflect the actual change, which involves logging errors instead of stopping the process.

- * [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Ignore undecodable txs in GetBlocksWithTxs.
+ * [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Modify error handling in GetBlocksWithTxs to log undecodable transactions instead of halting the process.

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	* [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Ignore undecodable txs in GetBlocksWithTxs.
	* [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Modify error handling in GetBlocksWithTxs to log undecodable transactions instead of halting the process.

---

Ensure the file ends with a single newline character.

+ 

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	* [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Ignore undecodable txs in GetBlocksWithTxs.
	* [#20323](https://github.com/cosmos/cosmos-sdk/pull/20323) Ignore undecodable txs in GetBlocksWithTxs.

[johnletey]

@tac0turtle Could we get this backported to v0.50.x?

[tac0turtle]

@Mergifyio backport release/v0.50.x

[mergify]

backport release/v0.50.x

✅ Backports have been created

• #20329 fix: allow tx decoding to fail in GetBlockWithTxs (backport #20323) has been created for branch release/v0.50.x but encountered conflicts