Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update grpc-gateway to v2 #18872

Closed
wants to merge 4 commits into from
Closed

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 22, 2023

Description

Closes: #8055

Update grpc-gateway to v2, which apparently fixes issues with encoding in query args.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@alexanderbez
Copy link
Contributor Author

This will require us to update github.com/cosmos/gogogateway...I'll get back to this later. Would appreciate some help on it if anyone has cycles.

@alexanderbez
Copy link
Contributor Author

@tac0turtle so correct me if I'm wrong here, but we're blocked here and we can't proceed because of downstream gogoproto right?

@tac0turtle
Copy link
Member

gateway v2 requires protoreflect to be present on the types. Since we dont use protov2 in modules then when we copy these into the module they dont have the correct types. There seems to be a standalone mode (https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/grpc_api_configuration/#using-an-external-configuration-file), we could look into adopting something like this. Not 100% sure what it involves

@tac0turtle
Copy link
Member

closing this for now, we should look into grpcgateway v2 standalone mode.

@tac0turtle tac0turtle closed this Jan 10, 2024
@julienrbrt julienrbrt deleted the bez/bump-grpc-dep branch August 29, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to grpc-gateway V2
2 participants