fix(x/feegrant)!: limit expired feegrant pruning to 200 per block #19314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -6,5 +6,5 @@ | |||
| ) | |||
|
|
|||
| func EndBlocker(ctx sdk.Context, k keeper.Keeper) { | |||
| k.RemoveExpiredAllowances(ctx) | |||
| k.RemoveExpiredAllowances(ctx, 200) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
mpoke
approved these changes
Feb 1, 2024
mpoke
reviewed
Feb 1, 2024
This is a partial backport of cosmos#18047. Txs were not migrated. EndBlocker behaviour was not changed since v47 x/feegrant::EndBlocker cannot produce an error during operation.
MSalopek
force-pushed
the
masa/backport-18047-partial-grant-prune
branch
from
5f3f534
to
1f30de6
Compare
mattverse
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Feb 5, 2024
mattverse
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Feb 6, 2024
…smos#19314) (#512) Co-authored-by: MSalopek <[email protected]>
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Feb 8, 2024
* De-dup param getting * Disable DenomOwners tracking * Fix some tests * chore(types): replace amino json encoder with stdlib * feat: config option to log gRPC queries (#503) * config option to log gRPC queries * clarify gRPC log comment * create var * remove quotes * go mod tidy * chore: fix CI (#509) * ci * lints and remove some unnecessary CI jobs * update tests go mod * more lints * remove denom owners since not implemented in osmosis * more lints * fix test values * implement nolint again * more test fixes * add back labeler as v4 * remove tabs and slash * update json to const * move file locations * push * fix seq num issue * Update tests/e2e/auth/vesting/suite.go * add back pwd * remove sonarcloud --------- Co-authored-by: Matt, Park <[email protected]> * Fix CI(#511) * perf: CacheCtx speedups (#504) * CacheKV speedups * Remove extra btree alloc * fix(x/feegrant)!: limit expired feegrant pruning to 200 per block (cosmos#19314) (#512) Co-authored-by: MSalopek <[email protected]> * feat: add testnetify logic (#506) * add testnetify logic * clarify explanation * handle errors * remove testnet app creator * simplify some logic * remove redundancy * lints * gci imports * add set store loader method * trigger upgrade flag * add extra comments to the CLI command * skip confirmation (#516) --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Matt, Park <[email protected]> Co-authored-by: MSalopek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial backport of #18047.
Txs and were not migrated.
EndBlocker behaviour was not changed since v47 x/feegrant::EndBlocker cannot produce an error during operation.
AutoCLI was not migrated because it does not exist on v47.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...