ci: bump go to 1.22

[julienrbrt]

Description

Bump CI to use Go 1.22, and simapp to use Go 1.22.
However, as the sdk is a library, and we don't have Go 1.22 specific features we want to use, we keep our minimum Go version to Go 1.21.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Chores
  • Updated Go version from 1.21 to 1.22 across various modules and Dockerfiles to enhance performance and compatibility.
  • Added toolchain declarations for go1.22.0 in relevant configuration files.
  • Updated flake.lock file with changes in nixpkgs dependency, reflecting version updates.

[coderabbitai]

Walkthrough

The recent updates involve upgrading the Go version from 1.21 to 1.22 across various components of the project, including simapp, test configurations, Dockerfiles, and go.work.example. These changes ensure compatibility with Go 1.22 and incorporate new features and improvements.

Changes

Files	Change Summary
simapp/go.mod, tests/go.mod, tests/starship/tests/go.mod	Updated Go version to 1.22 and added toolchain declarations for go1.22.0
Dockerfile, contrib/devtools/Dockerfile, contrib/images/simd-dlv/Dockerfile, contrib/images/simd-env/Dockerfile	Changed base image to golang:1.22-alpine
go.work.example	Updated Go version and toolchain version
flake.lock	Updated nixpkgs dependency with timestamp, narHash, and rev changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between d3120f5 and 1fe5a0b.

Files selected for processing (19)

• .github/workflows/build.yml (1 hunks)
• .github/workflows/codeql-analysis.yml (1 hunks)
• .github/workflows/dependabot-update-all.yml (1 hunks)
• .github/workflows/dependencies-review.yml (1 hunks)
• .github/workflows/lint.yml (1 hunks)
• .github/workflows/release-confix.yml (1 hunks)
• .github/workflows/release-cosmovisor.yml (1 hunks)
• .github/workflows/release.yml (1 hunks)
• .github/workflows/sims-047.yml (5 hunks)
• .github/workflows/sims-050.yml (5 hunks)
• .github/workflows/sims-nightly.yml (2 hunks)
• .github/workflows/sims.yml (4 hunks)
• .github/workflows/starship-tests.yml (1 hunks)
• .github/workflows/test.yml (30 hunks)
• Dockerfile (1 hunks)
• go.work.example (1 hunks)
• simapp/go.mod (1 hunks)
• tests/go.mod (1 hunks)
• tests/starship/tests/go.mod (1 hunks)

Files skipped from review due to trivial changes (9)

• .github/workflows/build.yml
• .github/workflows/dependencies-review.yml
• .github/workflows/lint.yml
• .github/workflows/release.yml
• .github/workflows/sims-050.yml
• .github/workflows/sims-nightly.yml
• .github/workflows/sims.yml
• .github/workflows/test.yml
• simapp/go.mod

Additional comments: 8

go.work.example (2)

• 1-1: Update to Go 1.22 is correct and aligns with the PR objectives.
• 3-3: Toolchain version update to go1.22.0 is correct and consistent with the Go version update.

tests/go.mod (2)

• 3-3: Update to Go 1.22 is correct and aligns with the PR objectives.
• 5-5: Toolchain version update to go1.22.0 is correct and consistent with the Go version update.

tests/starship/tests/go.mod (4)

• 3-3: The Go version is correctly updated to 1.22, aligning with the PR objectives to use Go 1.22 in CI processes and specific applications.
• 5-5: The addition of toolchain go1.22.0 is appropriate for specifying the Go version toolchain, ensuring that the correct version is used for builds.
• 1-8: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [7-35]

Ensure that the local path replacements in the replace directive are correctly pointing to the intended modules and versions, especially considering the update to Go 1.22.

• 1-8: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [37-205]

Review the require directives for both direct and indirect dependencies to ensure they are compatible with Go 1.22 and do not introduce any version conflicts or deprecated packages.

[testinginprod]

I say we wait a little bit before merging since it's not been updated everywhere (eg: homebrew)

[julienrbrt]

I say we wait a little bit before merging since it's not been updated everywhere (eg: homebrew)

Makes sense. It isn't updated on nixpkgs either, so ci won't let it go through.

[tac0turtle]

I think we have to remove this to allow people to use lower versions

[julienrbrt]

Yes, this is why it is only in simapp and packages that depends on simapp (tests and starship tests)

[coderabbitai]

Review Status

Actionable comments generated: 6

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 1fe5a0b and 3b9f912.

Files selected for processing (4)

• contrib/devtools/Dockerfile (1 hunks)
• contrib/images/simd-dlv/Dockerfile (1 hunks)
• contrib/images/simd-env/Dockerfile (1 hunks)
• flake.nix (1 hunks)

Files skipped from review due to trivial changes (1)

• contrib/images/simd-dlv/Dockerfile

Additional comments: 5

contrib/devtools/Dockerfile (2)

• 6-6: Ensure all dependencies installed via apk add and npm install are compatible with Alpine Linux running with Go 1.22 to avoid potential runtime issues.
• 6-6: Verify that the versions of the tools installed with go install are compatible with Go 1.22 to ensure the Docker image functions as expected.

contrib/images/simd-env/Dockerfile (2)

• 1-1: Updating to golang:1.22-alpine is aligned with the PR objectives. Ensure all dependencies and build tools are compatible with this Go version.
• 1-1: Verify that the make clean build command is fully compatible with Go 1.22 and does not rely on deprecated or removed features.

flake.nix (1)

• 56-56: Updating to go_1_22 in buildInputs aligns with the PR objectives. Ensure all dependencies specified in the Nix expression are compatible with Go 1.22.

[julienrbrt]

We just now need to wait until homebrew bumps Go and nixpkgs as well: Homebrew/homebrew-core#157782, then let's merge.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 3b9f912 and 682b041.

Files selected for processing (3)

• simapp/go.mod (1 hunks)
• tests/go.mod (1 hunks)
• tests/starship/tests/go.mod (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• simapp/go.mod
• tests/go.mod
• tests/starship/tests/go.mod

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 682b041 and 36c0051.

Files selected for processing (5)

• Dockerfile (1 hunks)
• contrib/images/simd-env/Dockerfile (1 hunks)
• simapp/go.mod (1 hunks)
• tests/go.mod (1 hunks)
• tests/starship/tests/go.mod (1 hunks)

Files skipped from review as they are similar to previous changes (5)

• Dockerfile
• contrib/images/simd-env/Dockerfile
• simapp/go.mod
• tests/go.mod
• tests/starship/tests/go.mod

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 36c0051 and 7b589dc.

Files selected for processing (3)

• simapp/go.mod (1 hunks)
• tests/go.mod (1 hunks)
• tests/starship/tests/go.mod (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• simapp/go.mod
• tests/go.mod
• tests/starship/tests/go.mod

[julienrbrt]

@yihuang any help here with nix: https://github.com/cosmos/cosmos-sdk/actions/runs/7976846552/job/21778336332?pr=19396
I don't understand what's wrong 🥲

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 7b589dc and b5acd8a.

Files selected for processing (3)

• simapp/go.mod (1 hunks)
• tests/go.mod (1 hunks)
• tests/starship/tests/go.mod (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• simapp/go.mod
• tests/go.mod
• tests/starship/tests/go.mod

[yihuang]

@yihuang any help here with nix: https://github.com/cosmos/cosmos-sdk/actions/runs/7976846552/job/21778336332?pr=19396 I don't understand what's wrong 🥲

it says, error: go.mod specified Go version 1.22, but no compatible Go attribute could be found., which means it can't find go_1_22 in current nixpkgs, we need to pin to a later nixpkgs version which has go 1.22 packaged. currently, we use the master branch which is the most up-to-date branch, but we need to update the commit rev in the flake.lock file, you can do this by running:

nix flake update nixpkgs

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between b5acd8a and 11119c8.

Files selected for processing (1)

• flake.lock (1 hunks)

Additional comments: 1

flake.lock (1)

• 46-50: The updates to the nixpkgs dependency in the flake.lock file, including changes to the lastModified, narHash, and rev values, are appropriate for aligning the Nix environment with the updated Go version 1.22. These changes ensure that the build environment and dependencies are consistent with the new requirements. It's important to verify that these updates do not introduce any compatibility issues with the existing codebase or other dependencies.