Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update documentation specifying the behaviour of CancelUnbondingDelegation on jailed validators #19415

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Feb 13, 2024

Description

Closes: #19279


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation
    • Updated the staking guide to note that canceling unbonding delegations from jailed validators is not supported.

Copy link
Contributor

coderabbitai bot commented Feb 13, 2024

Walkthrough

Walkthrough

The recent update addresses the issue where users were unable to cancel unbonding delegations from jailed validators. This was identified as a bug, and the documentation has been updated to clarify that canceling unbond delegations from jailed validators is not supported. This change aims to set correct expectations and prevent confusion for users interacting with the staking module.

Changes

File Change Summary
x/staking/README.md Added note that canceling unbond delegations from jailed validators is not supported.

Assessment against linked issues

Objective Addressed Explanation
#19279: Unable to cancel unbonding delegation of jailed validators The issue was acknowledged by updating the documentation to reflect that this behavior is expected and not supported, rather than fixing the functionality to allow canceling unbonding delegations from jailed validators.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@likhita-809 likhita-809 marked this pull request as ready for review February 13, 2024 11:07
@likhita-809 likhita-809 requested a review from a team as a code owner February 13, 2024 11:07
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between 8c002c6 and 79b4dd3.
Files selected for processing (1)
  • x/staking/README.md (2 hunks)
Additional comments: 1
x/staking/README.md (1)
  • 704-710: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [707-722]

The note added to the MsgCancelUnbondingDelegation message documentation correctly specifies that canceling unbond delegations from jailed validators is not supported. This clarification is essential for users and developers interacting with the staking module. The documentation is clear and directly addresses the issue raised in the related GitHub issue.

@tac0turtle tac0turtle added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 26d30f2 Feb 13, 2024
54 of 55 checks passed
@tac0turtle tac0turtle deleted the likhita/19279-docs branch February 13, 2024 12:45
@alexanderbez
Copy link
Contributor

Thanks @likhita-809!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to cancel unbonding delegation of jailed validators
4 participants