fix: use client/v2 v2.0.0-beta3; fix broken client.toml usage #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
MSalopek
force-pushed
the
fix/update-root-cmd-v50
branch
from
e8fd320
to
94ed1f8
Compare
MSalopek
added
the
scope: CLI
|
Is there any automated testing we have that would help us confirm whether this fixes the issue, or do we have to check manually? |
Tests are with Hypha, we're migrating parts of it here. Easiest way to test is to spin up a local gaia with non-default API port ( E.g. Before the fix: gaiad status
// fails with node not available on 127.0.0.1:26657 [the default!] -- node is actually on 26658
gaiad status --node tcp://127.0.0.1:26658
// passesAfter the fix: gaiad status
// passes because `node = "tcp://localhost:26658"` from config.toml gets applied |
dusan-maksimovic
approved these changes
Jul 22, 2024
p-offtermatt
approved these changes
Jul 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix: use client/v2 v2.0.0-beta3; fix broken client.toml usage * Update root.go (cherry picked from commit 27da5e8)
MSalopek
added a commit
that referenced
this pull request
Jul 22, 2024
…#3224) * fix: use client/v2 v2.0.0-beta3; fix broken client.toml usage * Update root.go (cherry picked from commit 27da5e8) Co-authored-by: MSalopek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered during testing.
The CLI would ignore the variables from
client.tomlwhich forced operators to always use--node <IP:port>command line options.The fix consists of changing
root.gocmd wiring and updatingcosmossdk.io/client/v2v2.0.0-beta3. The application does not use depinject.Related: