Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump capability to v1.0.1 #6747

Merged
merged 7 commits into from
Jul 4, 2024
Merged

deps: bump capability to v1.0.1 #6747

merged 7 commits into from
Jul 4, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added the dependencies Issues or PRs to update a dependency label Jul 2, 2024
crodriguezvega
crodriguezvega commented Jul 2, 2024
View reviewed changes
e2e/go.mod
Comment on lines +3 to +5
go 1.22.2

toolchain go1.22.0
toolchain go1.22.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets updated when I do make tidy-all...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is one of the dependencies requiring a more recent version?

@crodriguezvega crodriguezvega marked this pull request as ready for review July 3, 2024 10:15
@crodriguezvega
Copy link
Contributor Author

crodriguezvega commented Jul 3, 2024 •
edited
Loading

Opening this for review, although yesterday I saw something strange: locally, VS Code indicates in the go.mod that instead of picking up cosmossdk.io/core v0.11.0 (which is the one specified in the go.mod), picks up v0.12.0, which gives build errors. If somebody else could try locally as well to check if they have the same behaviour, that would be nice.

DimitrisJim
DimitrisJim reviewed Jul 3, 2024
View reviewed changes
e2e/go.mod Outdated
@@ -281,3 +282,5 @@ replace github.com/cosmos/ibc-go/modules/light-clients/08-wasm => ../modules/lig
replace github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

replace cosmossdk.io/core => cosmossdk.io/core v0.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can repro, still tryint to figure out why it is getting bumped

DimitrisJim
DimitrisJim reviewed Jul 3, 2024
View reviewed changes
e2e/go.mod Outdated
@@ -35,7 +35,7 @@ require (
cosmossdk.io/api v0.7.5 // indirect
cosmossdk.io/client/v2 v2.0.0-beta.2 // indirect
cosmossdk.io/collections v0.4.0 // indirect
cosmossdk.io/core v0.12.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't figure out something that was bumping this indirect? switching it just makes things happy. if you remember how/when this was bumped, that would be helpful!

This was referenced Jul 3, 2024
Closed
Closed
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@crodriguezvega crodriguezvega added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 8c79fac Jul 4, 2024
88 of 94 checks passed
@crodriguezvega crodriguezvega deleted the carlos/capability-v1.0.1 branch July 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@chatton chatton Awaiting requested review from chatton

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
dependencies Issues or PRs to update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crodriguezvega @DimitrisJim @colin-axner