Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock ibc module v2 #7398

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Oct 7, 2024

Description

Review after #7392

This PR adds the scaffolding for the mock v2 application, template comments in place and type assertion to ensure the remainder of the functions get filled out as those handlers are introduced.

closes: #7373


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Oct 7, 2024

@chatton chatton merged commit 8271fce into feat/ibc-eureka Oct 7, 2024
64 of 65 checks passed
@chatton chatton deleted the cian/issue#7373-add-mock-ibc-module-v2 branch October 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants