chore: add RecvPacket to V2 #7399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
|
closes #7370 I think |
chatton
approved these changes
Oct 7, 2024
Comment on lines
56
to
57
| sdkCtx.Logger().Error("send packet failed", "source-id", packet.SourceId, "error", errorsmod.Wrap(err, "send packet failed")) | ||
| return nil, errorsmod.Wrapf(err, "send packet failed for source id: %s", packet.SourceId) |
There was a problem hiding this comment.
we should be logging receive packet here, we can also include the dest-id maybe here
| panic("implement me") | ||
| func (k *Keeper) RecvPacket(ctx context.Context, msg *channeltypesv2.MsgRecvPacket) (*channeltypesv2.MsgRecvPacketResponse, error) { | ||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| packet := msg.Packet |
There was a problem hiding this comment.
[nit] I think we typically just access msg.Packet when needed rather than storing a separate var here, don't think this is required.
There was a problem hiding this comment.
Yeah this was supposed to be "temporary" and I forgot, will remove!
|
|
||
| signer, err := sdk.AccAddressFromBech32(msg.Signer) | ||
| if err != nil { | ||
| sdkCtx.Logger().Error("send packet failed", "error", errorsmod.Wrap(err, "invalid address for msg Signer")) |
| // return nil, err | ||
| // } | ||
| // } | ||
|
|
There was a problem hiding this comment.
worth mentioning that the remainder of this fn should be wired up in #7354
Co-authored-by: Cian Hatton <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.