Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use header info for interchain accounts address generation #7713

Merged
merged 2 commits into from
Dec 18, 2024
Merged

refactor: use header info for interchain accounts address generation #7713

merged 2 commits into from
Dec 18, 2024

Conversation

damiannolan
Copy link
Contributor

Description

Removes UnwrapSDKContext for interchain accounts.
Now uses block hash (merkle root of block) instead of dataHash for interchain accounts address generation.

The ctx.BlockHeader is deprecated and recommended to now use service based approach. The HeaderService provided by cosmos-sdk returns header.Info which only contains appHash, hash (merkle root of block), height, time and chainID.

It is recommended to use cometservice when anything else is needed.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review December 17, 2024 18:55
gjermundgaraba
gjermundgaraba approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! LGTM!

AdityaSripal
AdityaSripal approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle. But my understanding is that we can just go back to deterministic address generation because addresses are no longer instantiated as base accounts on receive. So we no longer have to protect against DoS attacks with the new sdk changes

modules/apps/27-interchain-accounts/types/account.go
buf = append(buf, header.AppHash...)
buf = append(buf, header.DataHash...)
buf = append(buf, headerInfo.AppHash...)
buf = append(buf, headerInfo.Hash...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we no longer get access to datahash directly? Is there a reason it isn't in header info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a question for the sdk team I think.

@damiannolan
Copy link
Contributor Author

Looks good in principle. But my understanding is that we can just go back to deterministic address generation because addresses are no longer instantiated as base accounts on receive. So we no longer have to protect against DoS attacks with the new sdk changes

Agree! That skipped my mind about the removal of account creation from SendCoins. I guess we could removal the block fields entirely from the address generation now. I will merge this PR and that can be discussed later if its something that wants to be done.

@damiannolan damiannolan added this pull request to the merge queue Dec 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
141 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Merged via the queue into main with commit c15bb5c Dec 18, 2024
71 checks passed
@damiannolan damiannolan deleted the damian/update-icahost-address-generation branch December 18, 2024 08:37
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
Revert "refactor: use header info for interchain accounts address gen…
73a48a6 
…eration (#7713)"

This reverts commit c15bb5c.
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
Revert "refactor: use header info for interchain accounts address gen…
acbffe9 
…eration (#7713)"

This reverts commit c15bb5c.
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
chore: revert SDK to 0.50 (#7932)
bf71bdd 
* Revert "chore: bump to sdk v0.52-rc.2 (#7882)"

This reverts commit 4e54444.

* Revert "chore: clean up module impls (#7865)"

This reverts commit d91eb00.

* Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)"

This reverts commit 39b190a.

* Revert "chore: bump sdk versions (#7843)"

This reverts commit c29c1ab.

* Revert "fix: wasm docker file + wasm simapp gas limit (#7830)"

This reverts commit 7f0cf54.

* Revert "chore: use header service in localhost client (#7757)"

This reverts commit 0bea84d.

* Revert "refactor: ibc core runtime env (#7601)"

This reverts commit f5e1a4c.

* Revert "refactor: use branch service in 29-fee (#7732)"

This reverts commit d50f7ba.

* Revert "chore: address some linter complaints (#7734)"

This reverts commit 83fdb7f.

* Revert "chore: refactor event service to 29-fee (#7728)"

This reverts commit 0b2866d.

* Revert "refactor: update 29-fee to use runtime.Environment (#7617)"

This reverts commit c8dc02c.

* Revert "refactor: use event service in transfer mod (#7725)"

This reverts commit 0e72d08.

* Revert "refactor: update transfer to use runtime.Environment (#7615)"

This reverts commit fd6a78a.

* Revert "Remove circuit module (#7715)"

This reverts commit 39d8547.

* Revert "refactor: use header info for interchain accounts address generation (#7713)"

This reverts commit c15bb5c.

* Revert "refactor: update icahost to use runtime.Environment (#7600)"

This reverts commit 7aae649.

* Revert "chore: update import alias to align (#7710)"

This reverts commit a14feef.

* Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)"

This reverts commit 8575743.

* fix unwanted reverts

* remove invariant

* lint

* last go1.23 change

* remove unecessary testing keeper

* update go version in dockerfile

* fix docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damiannolan @gjermundgaraba @AdityaSripal