Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use context.Context and appmodule.Environment in 08-wasm #7880

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

technicallyty
Copy link
Collaborator

@technicallyty technicallyty commented Jan 24, 2025

Description

stacked PR of #7866

  • removes most usage of sdk.Context. I left some over in the querier file as they seem dependent on wasmd. Feel free to correct me if im wrong here, or if we have room to change this. I'm not sure how its used externally and do not want to catastrophically break things.

supercedes: #7836

Closes: #7712


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@technicallyty technicallyty marked this pull request as ready for review January 24, 2025 18:55
@technicallyty technicallyty changed the base branch from main to tyler/core-services January 24, 2025 18:59
@technicallyty technicallyty linked an issue Jan 24, 2025 that may be closed by this pull request
10 tasks
Base automatically changed from tyler/core-services to main January 25, 2025 17:35
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to cosmos-sdk appmodule.Environment in ibc
1 participant