chore: remove all use of x/params
#7900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
| @@ -10,3 +10,6 @@ const ( | |||
| // ParamsKey is the store key for the interchain accounts controller parameters | |||
| ParamsKey = "params" | |||
| ) | |||
|
|
|||
| // KeyControllerEnabled is the store key for ControllerEnabled Params for legacy purposes. | |||
| var KeyControllerEnabled = []byte("ControllerEnabled") | |||
There was a problem hiding this comment.
I can't see much reason for this to be left behind now?
Looking it up on this branch, it looks like it is only used in tests, which also tells me there might be more code to remove?
| m.keeper.SetParams(ctx, params) | ||
| m.keeper.Logger.Info("successfully migrated ica/host submodule to self-manage params") | ||
| } | ||
| func (Migrator) MigrateParams(_ context.Context) error { |
There was a problem hiding this comment.
Nah, let's just delete the whole thing.
| var ( | ||
| // KeyHostEnabled is the store key for HostEnabled Params for legacy purposes. | ||
| // Deprecated: this will be removed. | ||
| KeyHostEnabled = []byte("HostEnabled") |
modules/apps/callbacks/go.mod
Outdated
| @@ -58,6 +57,7 @@ require ( | |||
| cosmossdk.io/x/evidence v0.0.0-00010101000000-000000000000 // indirect | |||
| cosmossdk.io/x/group v0.0.0-00010101000000-000000000000 // indirect | |||
| cosmossdk.io/x/nft v0.0.0-00010101000000-000000000000 // indirect | |||
| cosmossdk.io/x/params v0.0.0-00010101000000-000000000000 // indirect | |||
There was a problem hiding this comment.
Should there be anything left to keep this around?
|
|
||
| m.keeper.SetParams(ctx, params) | ||
| m.keeper.Logger.Info("successfully migrated transfer app self-manage params") | ||
| func (Migrator) MigrateParams(_ context.Context) error { |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the now unsupported
x/paramsmodule in ibc-go v10. Apps moving to Cosmos SDK v0.52.x will need to removex/paramsso removing it fromibc-gowill remove help remove it entirely from an app using the stack.For now, I just moved the existing
MigrateParamsfunctions to be a no-op, but I can remove them if desired.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.