remove Empty

cosmos · Nov 10, 2023 · bd128be · bd128be
1 parent defa1f5
commit bd128be
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/crates/ibc/src/core/ics24_host/identifier.rs b/crates/ibc/src/core/ics24_host/identifier.rs
@@ -526,8 +526,6 @@ pub enum IdentifierError {
     UnformattedRevisionNumber { chain_id: String },
     /// revision number overflowed
     RevisionNumberOverflow,
-    /// identifier cannot be empty
-    Empty,
 }
 
 #[cfg(feature = "std")]

diff --git a/crates/ibc/src/core/ics24_host/identifier/validate.rs b/crates/ibc/src/core/ics24_host/identifier/validate.rs
@@ -7,11 +7,6 @@ const VALID_SPECIAL_CHARS: &str = "._+-#[]<>";
 /// [`ICS-24`](https://github.com/cosmos/ibc/tree/main/spec/core/ics-024-host-requirements#paths-identifiers-separators)]
 /// spec.
 pub fn validate_identifier_chars(id: &str) -> Result<(), Error> {
-    // Check identifier is not empty
-    if id.is_empty() {
-        return Err(Error::Empty);
-    }
-
     // Check that the identifier comprises only valid characters:
     // - Alphanumeric
     // - `.`, `_`, `+`, `-`, `#`
@@ -210,13 +205,6 @@ mod tests {
         assert!(id.is_err())
     }
 
-    #[test]
-    fn parse_invalid_id_empty() {
-        // invalid id empty
-        let id = validate_identifier_chars("");
-        assert!(id.is_err())
-    }
-
     #[test]
     fn parse_invalid_id_path_separator() {
         // invalid id with path separator