Update PULL_REQUEST_TEMPLATE.md #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the PR template to put a reminder, so that when we do new version releases we notify the comms team about it in advance. Signed-off-by: Adi Seredinschi <[email protected]>
rnbguy
reviewed
Jan 30, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -26,3 +26,5 @@ ______ | |||
|
|
|||
| - [ ] Reviewed `Files changed` in the GitHub PR explorer. | |||
| - [ ] Manually tested (in case integration/unit/mock tests are absent). | |||
| - [ ] __If new version release__: Notify the comms team about the pending release and [prepare a message](https://www.notion.so/informalsystems/Communications-pipeline-b8c0eeb71dc24203a048fa6ccf189e1a?pvs=4) to announce it | |||
There was a problem hiding this comment.
It appears to be a link to a restricted page. Should it stay public?
There was a problem hiding this comment.
it should be a private page, shared with Andrea, then he will manage making the public communications out of that content in that private page.
There was a problem hiding this comment.
I meant, should the link address be visible to the public - even though not everyone can open it and read its content ? 😄
There was a problem hiding this comment.
Appreciate adding this @adizere 🙏
I've the same comment as Rano's. I'd suggest not pointing to a private page since it'll be in all PRs. What about adding it as an initial step into the RELEASES.md?
|
Does this fix it @rnbguy @Farhad-Shabani ? d8ca5c6 |
Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* Update PULL_REQUEST_TEMPLATE.md Updated the PR template to put a reminder, so that when we do new version releases we notify the comms team about it in advance. Signed-off-by: Adi Seredinschi <[email protected]> * using releases.md instead of PR template * Apply suggestions from code review Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> --------- Signed-off-by: Adi Seredinschi <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> Co-authored-by: Farhad Shabani <[email protected]> Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the PR template to put a reminder, so that when we do new version releases we notify the comms team about it in advance.
PR author checklist:
Reviewer checklist:
Files changedin the GitHub PR explorer.