Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add name for protobuf break workflow #378

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

colin-axner
Copy link
Contributor

Looking into #376, I was unable to add the buf breaking check as required, I believe due to a missing name (which I have added). I'm unsure if it'll be problematic that this CI won't be run on every pr?

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge and see how things go!

@colin-axner colin-axner merged commit 7033a83 into master Oct 7, 2024
1 check passed
@colin-axner colin-axner deleted the colin/ci branch October 7, 2024 14:58
@damiannolan
Copy link
Member

Looks like the protobuf workflow did not run on this PR. Probably due to a file filter(?) I assume!

It hasn't been run in over 2 weeks so this can't be selected as a requirement check for merging to master branch

@colin-axner
Copy link
Contributor Author

It hasn't been run in over 2 weeks so this can't be selected as a requirement check for merging to master branch

Yea, it's not run on every pr due to file filter. Is there any other changes we want to make to close #376?

@DimitrisJim
Copy link
Contributor

frankly, I think file filters for small projects might also be overkill. Would be fine if we rm'ed that and just added it in future if necessary.

Alternatively, can we do a faux trigger in a PR and then add it?

@colin-axner
Copy link
Contributor Author

frankly, I think file filters for small projects might also be overkill. Would be fine if we rm'ed that and just added it in future if necessary.

ah that's a great point. I can try to remove the file filter and see if the action runs. Agreed. ics23 gets so few pr's that there's no need to optimize. Tidying up crumbs at that point

@colin-axner
Copy link
Contributor Author

good idea @DimitrisJim #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants