replace TestHandleSlashPacketDistribution w/ TestSlashUndelegation #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
requested review from
jtremback,
sainoe,
danwt and
shaspitz
as code owners
mpoke
commented
Jan 3, 2023
| }{ | ||
| // infraction - delegate - undelegate - slash - mature consumer - mature provider | ||
| // TODO: this behavior is unexpected |
There was a problem hiding this comment.
This behavior is unexpected according to my understanding of slashing in Cosmos. Need to discuss with TM team.
There was a problem hiding this comment.
Is this already tracked as an issue?
sainoe
reviewed
Jan 4, 2023
sainoe
reviewed
Jan 4, 2023
|
Great work @mpoke. Just a few suggestions to shorten the test length. |
sainoe
approved these changes
Jan 4, 2023
shaspitz
reviewed
Jan 5, 2023
| err := so.fn(suite) | ||
| suite.Require().NoError(err) | ||
| for i, tc := range testCases { | ||
| providerKeeper := suite.providerApp.GetProviderKeeper() |
There was a problem hiding this comment.
To fully reset the state, we need to call SetupTest on e2e tests that have multiple cases. Otherwise I believe we're using the same store between cases
Suggested change
| providerKeeper := suite.providerApp.GetProviderKeeper() | |
| suite.SetupTest() | |
| providerKeeper := suite.providerApp.GetProviderKeeper() |
There was a problem hiding this comment.
Already doing it at the end of the for loop.
| }{ | ||
| // infraction - delegate - undelegate - slash - mature consumer - mature provider | ||
| // TODO: this behavior is unexpected |
There was a problem hiding this comment.
Is this already tracked as an issue?
shaspitz
approved these changes
Jan 5, 2023
* checkDelegatorBalance refactored out * fix comments
|
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestHandleSlashPacketDistributionis replaced withTestSlashUndelegation, which testsLinked issues
Related to #629
Type of change
Testing: Adds testing