chore: add rfc for canonical deployments #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 14 14
Lines 665 665
=======================================
Hits 664 664
Misses 1 1 ☔ View full report in Codecov by Sentry. |
| 1. Testnet - staging | ||
| - This is going to be secured with no timelock and contracts are going to be upgraded on every push to main. | ||
| 2. Testnet - production | ||
| - This is going to be the canonical deployment between EVM and the Hub. Contracts are going to be timelocked with a tiny delay and transactions will be signed using a Gnosis Safe to replicate mainnet conditions. |
There was a problem hiding this comment.
canonical testnet deployment, perhaps?
| 1. Fetch dependency data if needed (e.g. Router address if deploying Transfer) | ||
| 2. Deploy the contract onto the specified network | ||
| 3. Check for contract deployment success | ||
| 4. Update the mapping between address => deployment data (commit hash, initialization parameters) |
| 1. Testnet - automatically sign the transactions and upgrade the contract | ||
| 2. Dump the resulting transaction signature and parameters into an artifact | ||
|
|
||
| ### Deployment schema |
There was a problem hiding this comment.
It's not clear to me what this actually is. Is this the deployments that are live? The word "schema" threw me off a bit.
| 1. Deployment of contract instances | ||
| 2. Upgrading the contract proxies to the new instances | ||
|
|
||
| ### Deployment of contract instances |
There was a problem hiding this comment.
Are light clients separate from this process?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.