support for actions artifact-v4, Nix docker builds #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottand
force-pushed
the
fix-actions-artefact
branch
from
7d9626d
to
f13eb97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a breaking change in GHA's upload-artifact v4, which CI relied upon in order to merge Docker manifests.
To make the CI easier for me to maintain, the Dockerfile-based builds are gone in favour of a single Nix-based container build. This has the breaking change of dropping support for 32-bit ARM, and the benefit of bringing reproducible builds to container images. Given the armv6 images had practically no downloads, few if any existing users should be accepted (do please open an issue if this is you!).
This in turn makes leng practically a
FROM SCRACHimage, which reduces the image attack surface. Image size remains about the same (pretty small at 7MB).Because of the breaking changes above, this makes release 1.6