CBL-5209 : Implement Collection and Scope Database Accessor #3208
+204
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pasin
commented
Dec 15, 2023
•
pasin
commented
- Implemented Collection and Scope Database Accessor.
- The database object is retained in the collection and scope object unless the collection object is cached in the database object to avoid the circular reference.
- Only the default collection is cached in the database object as it’s commonly used in the old decrecated functions that are redirected to the default collection.
- Refactor the code as now the database object from collection will not be null. This made a lot of code simpler.
- Additonal : fixed collection's hash function.
- Companion PR: https://github.com/couchbaselabs/couchbase-lite-ios-ee/pull/190
* Implemented Collection and Scope Database Accessor. * The database object is retained in the collection and scope object unless the collection object is cached in the database object to avoid the circular reference. * Only the default collection is cached in the database object as it’s commonly used in the old decrecated functions that are redirected to the default collection. * Refactor the code as now the database object from collection will not be null. This made code simpler.
pasin
force-pushed
the
feature/CBL-5209
branch
from
0b7e49b to
9973601
Compare
jianminzhao
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.