-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antora assembler simplification #910
Draft
osfameron
wants to merge
9
commits into
release/3.2
Choose a base branch
from
antora-assembler-simplification
base: release/3.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+152,493
−3,256
Commits on Sep 13, 2024
-
First pass for simplification of complex partials
Run perl -ni -e 'print unless /^(\s*$|\/\/)/' \ modules/ROOT/pages/_partials/_show_glossary_links.adoc ... on the main abstracted partials. This is so that when antora-assembler inlines them, they won't have extra newlines and // comment lines that confuse the output. Additionally, manually add a comment to the block_tabbed_code partials, so that the source of includes can be tracked.
Configuration menu - View commit details
-
Copy full SHA for 60e8bf0 - Browse repository at this point
Copy the full SHA 60e8bf0View commit details -
run: ./simplify/simplify.sh This assumes that docs-site and docs-sync-gateway are siblings in the file tree. This sample only updates the android/database.adoc page for now (it builds everything, and all the rest should work in exactly the same way, I just haven't wired that part together yet.)
Configuration menu - View commit details
-
Copy full SHA for c59cc35 - Browse repository at this point
Copy the full SHA c59cc35View commit details
Commits on Oct 1, 2024
-
Run improved simplify script on all modules
* Extract `process` call to run on all modules, and all asciidoc files * {tabs} declarations get mangled (possibly same issue as https://gitlab.com/antora/antora-assembler/-/issues/17 ?) We now de-munge these
Configuration menu - View commit details
-
Copy full SHA for b4552b4 - Browse repository at this point
Copy the full SHA b4552b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bd2a19 - Browse repository at this point
Copy the full SHA 9bd2a19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4256e0a - Browse repository at this point
Copy the full SHA 4256e0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ccd834 - Browse repository at this point
Copy the full SHA 5ccd834View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa71985 - Browse repository at this point
Copy the full SHA aa71985View commit details -
demunge additional tabs anchors
these auto-generated anchors break tabs
Configuration menu - View commit details
-
Copy full SHA for 79d3d15 - Browse repository at this point
Copy the full SHA 79d3d15View commit details -
Configuration menu - View commit details
-
Copy full SHA for f78181e - Browse repository at this point
Copy the full SHA f78181eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.