Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3203: Don't store channel history for non-leaf revisions #6368

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

CBG-3203: Don't store channel history for non-leaf revisions #6368

wants to merge 27 commits into from
+424 −122

Commits on Apr 8, 2024

  1. Don't store channel history for non-leaf revisions

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    16fffbb View commit details
    Browse the repository at this point in the history

  2. Extend RevTree unmarshal test for more cases (conflicting revs with c… 

    …hannels in particular)
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    10507a7 View commit details
    Browse the repository at this point in the history

  3. Add failing test for non-leaf revisions containing channels

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    44b8fac View commit details
    Browse the repository at this point in the history

  4. Fix godoc describing wrong revtree winner due to inverse ASCII compar… 

    …ison
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    dc69d8b View commit details
    Browse the repository at this point in the history

  5. Only populate channels for leaf revisions on marshal/unmarshal

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    15ef848 View commit details
    Browse the repository at this point in the history

  6. Keep Channels_Old for backwards compatibility (reading existing marsh… 

    …alled revtrees)
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    058ce82 View commit details
    Browse the repository at this point in the history

  7. wip

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8b23e1e View commit details
    Browse the repository at this point in the history

  8. Build activeChannels from IsChannelRemoval based on sync.Channels

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5ce9e15 View commit details
    Browse the repository at this point in the history

  9. goimports

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f32d938 View commit details
    Browse the repository at this point in the history

  10. Remove leaf check from RevTree Unmarshal (assume JSON is always corre… 

    …ct and isn't storing non-leaf channelmap entries)
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8114336 View commit details
    Browse the repository at this point in the history

  11. Cleanup addRevision error formatting

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1ae9ded View commit details
    Browse the repository at this point in the history

  12. Skip leaf check when storing for ChannelMap - nil out parent channels… 

    … on addRevision
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8f70fdd View commit details
    Browse the repository at this point in the history

  13. Change TestRevTreeChannelMapLeafOnly assertion to non-winning leaf only

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    84ad764 View commit details
    Browse the repository at this point in the history

  14. Skip ChannelsMap storage on Marshal for the winning revision (it's st… 

    …ored elsewhere outside of the RevTree)
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    dc8985e View commit details
    Browse the repository at this point in the history

  15. Move RevTree channel info into tests

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4c8d9ed View commit details
    Browse the repository at this point in the history

  16. Change now false assertion in TestSyncFnOnPush

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    12da452 View commit details
    Browse the repository at this point in the history

  17. Handle winning revision logic in authorizeDoc

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9359d53 View commit details
    Browse the repository at this point in the history

  18. Make revCacheLoaderForDocument work for winning revision channels not… 

    … in history
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    29969e4 View commit details
    Browse the repository at this point in the history

  19. Fix missing context

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    eaec520 View commit details
    Browse the repository at this point in the history

  20. Store set of currentRevChannels on Document at unmarshal time

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3bfaaea View commit details
    Browse the repository at this point in the history

  21. Move currentRevChannels logic down into SyncData type

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    220c275 View commit details
    Browse the repository at this point in the history

  22. Remove old FIXMEs

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    52495bc View commit details
    Browse the repository at this point in the history

  23. simplify

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    fd3e91a View commit details
    Browse the repository at this point in the history

  24. Address PR comments (move logic into Unmarshal only - and don't set c… 

    …hannel info for winning rev)
    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    eacbe39 View commit details
    Browse the repository at this point in the history

  25. Return 404 from authorizeDoc when an uncached non-leaf rev is requested

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    25c2fab View commit details
    Browse the repository at this point in the history

  26. use errors.Is instead of ==

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1c0e4cd View commit details
    Browse the repository at this point in the history

  27. Fix duplicate UnmarshalJSON func for SyncData

    @bbrks
    bbrks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5698d3e View commit details
    Browse the repository at this point in the history