Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.1 Backport] CBG-4151: Memory-based rev cache size #7134

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Sep 26, 2024

CBG-4151

Clean cherry-picks for backport into 3.2.1

Integration Tests

* CBG-4135: new stat for rev cache capacity

* updated based on review

* fix linter

* lint again
* CBG-4032: memory based rev cache implementation

* make test pass with default collection + missing return param

* more issues with default collection test

* touch ups on comment + remove unused function

* updated for review

* further tidy up

* lint fix after refector test

* fixes from rebase

* updates based off review + some more refactoring
* CBG-4134: link rev cache memory limit config option to rev cache

* failing tests

* address commnets

* fix yaml lint

* fix failing test + mistake in docs

Signed-off-by: Gregory Newman-Smith <[email protected]>

---------

Signed-off-by: Gregory Newman-Smith <[email protected]>
* CBG-4234: clean up rev cache work

* new test
Copy link

github-actions bot commented Sep 26, 2024

Redocly previews

@bbrks bbrks requested a review from gregns1 September 26, 2024 10:40
gregns1
gregns1 previously approved these changes Sep 26, 2024
Copy link
Contributor

@gregns1 gregns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just that one part that we can either merge as is or manually update now before merging, i'll have a PR up against main now for it.

@gregns1 gregns1 merged commit f682b48 into release/3.2.1 Sep 27, 2024
41 checks passed
@gregns1 gregns1 deleted the CBG-4151 branch September 27, 2024 08:45
bbrks added a commit that referenced this pull request Oct 8, 2024
* CBG-4023: Removal unmarshalled body on the rev cache (#7030)

* CBG-4135: new stat for rev cache capacity (#7049)

* CBG-4135: new stat for rev cache capacity

* updated based on review

* fix linter

* lint again

* CBG-4032: memory based rev cache implementation (#7040)

* CBG-4032: memory based rev cache implementation

* make test pass with default collection + missing return param

* more issues with default collection test

* touch ups on comment + remove unused function

* updated for review

* further tidy up

* lint fix after refector test

* fixes from rebase

* updates based off review + some more refactoring

* CBG-4134: link rev cache memory limit config option to rev cache (#7084)

* CBG-4134: link rev cache memory limit config option to rev cache

* failing tests

* address commnets

* fix yaml lint

* fix failing test + mistake in docs

Signed-off-by: Gregory Newman-Smith <[email protected]>

---------

Signed-off-by: Gregory Newman-Smith <[email protected]>

* CBG-4234: clean up rev cache work (#7113)

* CBG-4234: clean up rev cache work

* new test

* CBG-4277: Remove unused totalBytesForHistory from getHistory (#7137)

---------

Signed-off-by: Gregory Newman-Smith <[email protected]>
Co-authored-by: Gregory Newman-Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants