Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor blip test client #7398

Merged
merged 1 commit into from
Feb 25, 2025
Merged

refactor blip test client #7398

merged 1 commit into from
Feb 25, 2025

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Feb 25, 2025

This is an intended noop refactor in prep for more work on this code.

  • separate each handler function into its method to make logical refactoring easier
  • consistently name pointer recievers to make it easier to match different layers of blip tester when readinghte code
  • remove perilous attachments lock function

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

This is an intended noop refactor in prep for more work on this code.

- separate each handler function into its method to make logical
  refactoring easier
- consistently name pointer recievers to make it easier to match
  different layers of blip tester
-
@torcolvin torcolvin merged commit 5cef02b into main Feb 25, 2025
44 of 45 checks passed
@torcolvin torcolvin deleted the ci-blip-test-refactor branch February 25, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants