Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4440: HLC implementation for blip tester client #7399

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Feb 25, 2025

CBG-4440

  • HLC implementation for value in CV for blip tester client
  • Using rosmar implementation now, so not ready to merge until rosmar is merged (this PR points to that PR in go mod)

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

Integration Tests

Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as-is - just wondering whether we can move the rosmar implementation into a location that can be used by both?

@gregns1 gregns1 self-assigned this Feb 25, 2025
@gregns1 gregns1 merged commit f2939ae into release/anemone Feb 26, 2025
42 checks passed
@gregns1 gregns1 deleted the CBG-4440 branch February 26, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants