Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DATASETS.md #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update DATASETS.md #94

wants to merge 1 commit into from

Conversation

julieaboyle1
Copy link
Collaborator

added subject info ( both N and IDs) for harrypotter, shinobi_training

@julieaboyle1
Update DATASETS.md
d689701 
added subject info ( both N and IDs) for harrypotter, shinobi_training
hyruuk
hyruuk requested changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@hyruuk hyruuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to remove the few sessions of sub-03 to stay consistent with the doc ? Or adjust the doc accordingly

@julieaboyle1
Copy link
Collaborator Author

agreed @hyruuk, can how many data points do we have for sub-03?

@hyruuk
Copy link
Collaborator

hyruuk commented Dec 22, 2022

We have about ~20 .bk2 files for sub-03, vs hundreds for the other subjects.

@pbellec
Copy link
Contributor

pbellec commented Jan 13, 2023

LGTM.

Please make a decision on the point raised by @hyruuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyruuk hyruuk hyruuk requested changes

@pbellec pbellec pbellec approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julieaboyle1 @hyruuk @pbellec