Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assembly AI annotations and gentle files #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

complexbrains
Copy link

This PR adds friends language annotations run by assembly AI and htk module, the accompanying dataset description file and assembly AI gentle files (that gives word by word onset, offset, duration of each movie segments.)

@bpinsard
Copy link
Contributor

bpinsard commented Apr 30, 2024

  • Unless I am missing something, why should we ship 3 different versions of the same annotation? It seems preferable to ship a single format, the simplest to use and most data efficient ( I would say the tsv that avoid redundant keys compared to json, we can add the confidence to the tsv to avoid losing infos).
  • I've randomely seen some character names without capital, maybe that would be worth having a filter to fix that.
  • the folder assembly_AI_json contains some tsvs, better not put json in the folder name if that's not all json.
  • assembly_AI_json/json_aa/s1 contains a few tsvs.
  • The tsvs should have a single sidecar to describe the columns.
  • there should be a README in that folder describing how the annotations were produced.
  • if we want the files to be better labeled, I would suggest something like task-s01e01a_desc-utterances_events.tsv that better describes the content/format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants