remove tx fee params setting before recursively calling executeWithRetry #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sudeepdino008
commented
Nov 9, 2023
sudeepdino008
commented
- the setting already happens at function entry, and is therefore redundant to do before recursively calling it.
- the setting already happens at function entry, and is therefore redundant to do before recursively calling it.
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 44.83% 44.83%
=======================================
Files 28 28
Lines 1927 1927
=======================================
Hits 864 864
Misses 1028 1028
Partials 35 35 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
noslav
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.