Fix cross-compilation issues #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using correct target and production dependencies only (no development dependencies).
Pull Request Test Coverage Report for Build 10587995752Details
💛 - Coveralls |
…hards build command already drops the binary it creates into a bin/ directory. For this same reason, we can also remove the mkdir step for that directory, since it seems the shards build command will create it for us.
…d (minor) make archiving verbose in build.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Summary
Properly build statically linked binaries with the
shards build --productioncommand.☑️ Checklist
shards buildcommand, using the correct target (src/cli.cr).--productionflag.crystal buildmethodbuild.ymlworkflow archives them.