refactor: simplify options handling #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventualbuddha
force-pushed
the
refactor/simplify-options-handling
branch
from
bc4e529 to
27265b2
Compare
eventualbuddha
force-pushed
the
refactor/simplify-options-handling
branch
from
27265b2 to
17085b5
Compare
kybarg
reviewed
Aug 5, 2020
| const {binarized, inverted} = binarize(data, width, height, shouldInvert); | ||
| let result = scan(tryInvertedFirst ? inverted : binarized); | ||
| if (!result && (options.inversionAttempts === "attemptBoth" || options.inversionAttempts === "invertFirst")) { | ||
| if (!result && (inversionAttempts === "attemptBoth" || inversionAttempts === "invertFirst")) { |
There was a problem hiding this comment.
I think this can be simplified to:
-if (!result && (inversionAttempts === "attemptBoth" || inversionAttempts === "invertFirst")) {
+if (!result && shouldInvert) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there's only one option, it seems simpler to just pull that one out into a local variable.