Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiTransaction.run which takes TransactionPayload. #243

Closed
wants to merge 2 commits into from

Conversation

liangxianzhe
Copy link
Contributor

For user who constructs the payload directly in Rust, this is slightly easier.

For user who constructs the payload directly in Rust, this is slightly
easier.
@liangxianzhe
Copy link
Contributor Author

Thinking more, I guess this is still not the ideal API. I'm dropping this PR.

Perhaps a better way is to define something like pub type Payload = (String, BTreeMap<String, DataValue>), and use this new type in both single query and multi transaction. The benefit is that once user construct the payload, they can feed it into either APIs. Currently API has some inconsistency: the single query takes a &str, while multi transaction takes a String.

What do you think? It is not high priority though since user can always do this themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant