feat: Add support for rust-rocksdb storage engine

[creatorrr]

• wip: Add support for rust-rocksdb storage engine

https://crates.io/crates/rocksdb

[creatorrr]

Comments / thoughts @zh217 ?

[keitharobertson]

I'm doing some testing and this is working for me and even fixed a bug with the rocksdb windows thread shutdown

[creatorrr]

@keitharobertson I’m not sure why the tests are failing though. Haven’t had a chance to sit and debug. Maybe I missed something?

[keitharobertson]

This test does not work for the old rocks implementation either. The problem is it is attempting to seek for the key with values (appended to the keys) included in the encoded prefix, which causes it to skip the first result. I can put a PR up with a fix, but it is unrelated to your implementation here.

[creatorrr]

Gotcha

[keitharobertson]

Nice job finding bugs with the tests

[creatorrr]

Thanks @keitharobertson! This is awesome. Committed your suggested changes. Another question is naming? storage-new-rocksdb and new-* seem weird to me… Maybe we can switch to rocksdb for the new one and rename the original to cozorocks-* ?

@zh217 what do you think?

[keitharobertson]

Thanks @keitharobertson! This is awesome. Committed your suggested changes. Another question is naming? storage-new-rocksdb and new-* seem weird to me… Maybe we can switch to rocksdb for the new one and rename the original to cozorocks-* ?

@zh217 what do you think?

Renaming the old one to cozorocks would be a breaking change so we probably don't want to do that. It is a different major version of rocks so maybe storage-rocksdb-9?

[creatorrr]

It won't be a breaking change at the cozoscript level though, right? I like rocksdb-9 naming scheme though.

[keitharobertson]

It won't be a breaking change at the cozoscript level though, right? I like rocksdb-9 naming scheme though.

yeah- I think it would only matter in Cargo.toml

[creatorrr]

yeah- I think it would only matter in Cargo.toml

Actually I think in cozo-bin, we might have to add a new flag too