Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): react should not be a devDependencies #442

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trollepierre
Copy link
Contributor

The 3 commits are self explicit.

about eslint plugin import, I think it should be added in cozy-scripts (once accepted by the team)

@trollepierre trollepierre force-pushed the eslint-import-no-extraneous-dep branch from 4447827 to ff702fb Compare August 12, 2022 10:08
@bundlemon
Copy link

bundlemon bot commented Aug 12, 2022

BundleMon

Files updated (1)
Status Path Size Limits
vendors/settings.(hash).js
827.09KB (+42.65KB +5.44%) -
Unchanged files (15)
Status Path Size Limits
app/settings.(hash).js
66.28KB -
intents/settings.(hash).js
39.8KB -
img/export-cozy-mail.(hash).svg
27.88KB -
app-settings.(hash).min.css
11.57KB -
img/import-cozy.(hash).svg
11.28KB -
img/double_authent_prez_banner.(hash).svg
4.44KB -
img/protect_data_point.(hash).svg
4.17KB -
img/niv_secu_point.(hash).svg
1.56KB -
intents-settings.(hash).min.css
1.28KB -
img/icon-bills.(hash).svg
719B -
img/icon-laptop.(hash).svg
437B -
img/icon-arrow-left.(hash).svg
419B -
img/icon-question-mark.(hash).svg
379B -
img/icon-check.(hash).svg
367B -
img/icon-phone.(hash).svg
342B -

Total files change +42.65KB +4.46%

Groups updated (1)
Status Path Size Limits
**/*.js
933.17KB (+42.65KB +4.79%) +5%
Unchanged groups (2)
Status Path Size Limits
img/.
51.93KB +5%
**/*.css
42.44KB +5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@acezard acezard self-requested a review August 12, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants