feat: Deprecates some component #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This is the list of deprecated component `ActionMenu`, `Alerter`, `BottomDrawer`, `Button`, `ButtonAction`, `Chip`, `CompositeRow`, `GridItem`, `Infos`, `InfosCarrousel`, `InlineCard`, `IntentModal`, `IntentOpener`, `Media`, `Menus`, `Modal`, `NarrowContent`, `Overlay`, `PercentageBar`, `PercentageLine`, `PushClientButton`, `QuotaAlert`, `Radio`, `RaisedList`, `ViewStack` These components are now in a `deprecated` subfolder. Use this codemods to migrate: ``` $ yarn global add @cozy/codemods $ jscodeshift -t $(yarn global dir)/node_modules/@cozy/codemods/src/transforms/transform-ui-deprecated-imports.js src --parser babel --ignore-pattern=src/targets/ --extensions js,jsx ```
JF-Cozy
force-pushed
the
feat/deprecation
branch
from
4ade23b
to
a7e6337
Compare
BundleMonFiles updated (1)
Unchanged files (2)
Total files change -517B -1.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Merkur39
approved these changes
Jun 28, 2023
|
🎉 This PR is included in version 87.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR nous déplaçons les composants dépréciés dans un dossier
/react/deprecated/, en rapport à #2363L'idée de base était de déplacer directement dans un nouveau dossier
/src/deprecatedmais cela représente beaucoup plus de travail, car au moment du build cela fait tout un nouveau dossier à prendre en compte. Il est plus simple de le faire en plusieurs temps.BREAKING CHANGE: This is the list of deprecated component
ActionMenu,Alerter,BottomDrawer,Button,ButtonAction,Chip,CompositeRow,GridItem,Infos,InfosCarrousel,InlineCard,IntentModal,IntentOpener,Media,Menus,Modal,NarrowContent,Overlay,PercentageBar,PercentageLine,PushClientButton,QuotaAlert,Radio,RaisedList,ViewStackThese components are now in a
deprecatedsubfolder. Use this codemods to migrate:PR du codemod : cozy/cozy-libs#2213
demo : https://jf-cozy.github.io/cozy-ui/react/
Les différences sur Argos sont dû au fait qu'on screenshot le chemin d'import des composants dans la doc, donc comme il a changé, Argos soulève les différences. Je n'ai rien remarqué d'autre...