Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move components from MuiCozyTheme folder #2465

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Conversation

JF-Cozy
Copy link
Collaborator

@JF-Cozy JF-Cozy commented Jun 28, 2023

Relatif à #2363

Dans un souhait de faire le ménage dans les dossiers de cozy-ui, on sort tous les composants du dossier MuiCozyTheme pour les mettre avec les autres, dans /react.

BREAKING CHANGE: We moved these components into /react folder.

This is the list of impacted components: MuiCozyTheme/Buttons, MuiCozyTheme/MuiBreadcrumbs, MuiCozyTheme/Dialog, MuiCozyTheme/Accordion, MuiCozyTheme/AccordionDetails, MuiCozyTheme/AccordionSummary, MuiCozyTheme/Divider, MuiCozyTheme/Grid, MuiCozyTheme/List, MuiCozyTheme/ListItem, MuiCozyTheme/ListItemIcon, MuiCozyTheme/ListItemSecondaryAction, MuiCozyTheme/ListSubheader, MuiCozyTheme/Menu, MuiCozyTheme/Switch, MuiCozyTheme/TextField

You can use this codemods to migrate:

$ yarn global add @cozy/codemods
$ jscodeshift -t $(yarn global dir)/node_modules/@cozy/codemods/src/transforms/transform-ui-muicozytheme-imports.js src --parser babel --ignore-pattern=src/targets/ --extensions js,jsx

demo : https://jf-cozy.github.io/cozy-ui/react/

PR codemods : cozy/cozy-libs#2215

no BC here, we will make one later on the parent folder
BREAKING CHANGE: you must replace `cozy-ui/transpiled/react/Breadcrumbs` by `cozy-ui/transpiled/react/legacy/Breadcrumbs`
no BC here, we will make one later and provide a codemod
no BC here, we will provide a codemods later do deal with this change
@JF-Cozy JF-Cozy changed the title feat: Deprecates some component feat: Move components from MuiCozyTheme folder Jun 28, 2023
@bundlemon
Copy link

bundlemon bot commented Jun 28, 2023

BundleMon

Unchanged files (3)
Status Path Size Limits
dist/cozy-ui.min.css
19.69KB +10%
transpiled/react/stylesheet.css
19.19KB +10%
dist/cozy-ui.utils.min.css
10.38KB +10%

Total files change +4B +0.01%

Unchanged groups (1)
Status Path Size Limits
transpiled/react/**
583.92KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

react/index.js Show resolved Hide resolved
BREAKING CHANGE: We moved these components into `/react` folder.

This is the list of impacted components: `MuiCozyTheme/Buttons`, `MuiCozyTheme/MuiBreadcrumbs`, `MuiCozyTheme/Dialog`, `MuiCozyTheme/Accordion`, `MuiCozyTheme/AccordionDetails`, `MuiCozyTheme/AccordionSummary`, `MuiCozyTheme/Divider`, `MuiCozyTheme/Grid`, `MuiCozyTheme/List`, `MuiCozyTheme/ListItem`, `MuiCozyTheme/ListItemIcon`, `MuiCozyTheme/ListItemSecondaryAction`, `MuiCozyTheme/ListSubheader`, `MuiCozyTheme/Menu`, `MuiCozyTheme/Switch`, `MuiCozyTheme/TextField`

You can use this codemods to migrate: 

```
$ yarn global add @cozy/codemods
$ jscodeshift -t $(yarn global dir)/node_modules/@cozy/codemods/src/transforms/transform-ui-muicozytheme-imports.js src --parser babel --ignore-pattern=src/targets/ --extensions js,jsx
```
This is a tricks to be able to build the doc with old version of harvest
that import these components. We should remove this after
dealing with the BC in harvest
@JF-Cozy JF-Cozy merged commit c2f4acd into master Jun 28, 2023
2 checks passed
@JF-Cozy JF-Cozy deleted the feat/muicozytheme branch June 28, 2023 16:45
@cozy-bot
Copy link

🎉 This PR is included in version 88.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants